fix(cdk/text-field): avoid page jump on auto-resize #32605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorentinDeBoisset
force-pushed
the
main
branch
from
e6e1a3a to
66403ca
Compare
Contributor
|
reassigning to @crisbeto since he was the author of the firefox-specific fix |
crisbeto
reviewed
Jan 6, 2026
| const element = this._textareaElement; | ||
| const previousMargin = element.style.marginBottom || ''; | ||
| const isFirefox = this._platform.FIREFOX; | ||
| const needsMarginFiller = isFirefox && this._hasFocus; |
Member
There was a problem hiding this comment.
I think we still need the _hasFocus part of this check. Otherwise we'll end up applying the margin on elements the user isn't interacting with.
When we measure the size of the autosize textarea, we make it temporarily smaller which can cause the scroll position to shift. These changes add a workaround that assign a temporary margin-bottom while measuring. Fixes angular#23834
CorentinDeBoisset
force-pushed
the
main
branch
from
66403ca to
b96a69b
Compare
crisbeto
approved these changes
Jan 13, 2026
crisbeto
added
action: merge
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we measure the size of the autosize textarea, we make it temporarily smaller which can cause the scroll position to shift. These changes add a workaround that assign a temporary margin-bottom while measuring.
Fixes #23834